Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update default interval_max argument of integrate_profile #481

Closed
adokter opened this issue Aug 23, 2021 · 2 comments
Closed

update default interval_max argument of integrate_profile #481

adokter opened this issue Aug 23, 2021 · 2 comments
Assignees
@adokter
Labels
enhancement
Milestone
0.6.0

Comments

@adokter
Copy link
Owner

adokter commented Aug 23, 2021 •
edited
Loading

Especially for time-series that do not have daytime data, the current default behavior (Inf) leads to unintuitive results. Instead switch to using an interval that is somewhat larger than the typical time-interval
@adokter adokter self-assigned this Aug 23, 2021
@adokter adokter added the sprint label Aug 23, 2021
@adokter adokter added this to the 0.6.0 milestone Aug 23, 2021
@adokter
Copy link
Owner Author

adokter commented Aug 23, 2021 •
edited
Loading

  • interval_max identifies which time intervals are too large
  • Add a parameter interval_replace containing the value to which you want to shorten those intervals. interval_replace could be by default the mean of all intervals, excluding those > interval_max
  • add a warning when interval_max < median time interval

@adokter adokter changed the title update default interval_max argument of integrate_profile from Inf to the median time-series time-interval update default interval_max argument of integrate_profile Sep 2, 2021
@adokter adokter added enhancement and removed sprint labels May 2, 2022
adokter added a commit that referenced this issue May 3, 2022
@adokter
add interval_replace argument to integrate_profile (#481)
c86741c
@adokter
Copy link
Owner Author

adokter commented May 3, 2022

closed by c86741c

@adokter adokter closed this as completed May 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@adokter adokter

Labels
enhancement
Projects
None yet
Milestone
0.6.0
Development

No branches or pull requests
1 participant
@adokter