feat: Broken internal links validate and update #635
+119
−23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…test coverage for validateURLs
…es separate checks.
alinarublea
reviewed
Feb 27, 2025
packages/spacecat-shared-content-client/src/clients/content-client.js
Outdated
Show resolved
Hide resolved
alinarublea
reviewed
Feb 27, 2025
packages/spacecat-shared-content-client/src/clients/content-client.js
Outdated
Show resolved
Hide resolved
…nd-update' into broken-internal-links-validate-and-update # Conflicts: # packages/spacecat-shared-content-client/src/clients/content-client.js
|
This PR will trigger a patch release when merged. |
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
packages/spacecat-shared-content-client/test/clients/content-client.test.js
Fixed
Show fixed
Hide fixed
packages/spacecat-shared-content-client/test/clients/content-client.test.js
Fixed
Show fixed
Hide fixed
packages/spacecat-shared-content-client/test/clients/content-client.test.js
Fixed
Show fixed
Hide fixed
packages/spacecat-shared-content-client/test/clients/content-client.test.js
Fixed
Show fixed
Hide fixed
packages/spacecat-shared-content-client/test/clients/content-client.test.js
Fixed
Show fixed
Hide fixed
packages/spacecat-shared-content-client/test/clients/content-client.test.js
Fixed
Show fixed
Hide fixed
packages/spacecat-shared-content-client/test/clients/content-client.test.js
Fixed
Show fixed
Hide fixed
packages/spacecat-shared-content-client/test/clients/content-client.test.js
Fixed
Show fixed
Hide fixed
packages/spacecat-shared-content-client/test/clients/content-client.test.js
Fixed
Show fixed
Hide fixed
alinarublea
reviewed
Feb 28, 2025
| @@ -349,4 +354,31 @@ export default class ContentClient { | |||
|
|
|||
| this.#logDuration('updateRedirects', startTime); | |||
| } | |||
|
|
|||
| async updateBrokenInternalLinks(path, brokenLinks) { | |||
There was a problem hiding this comment.
I was thinking again here and I think it would be better if we receive in the beginning just one brokenLink
alinarublea
changed the title
This reverts commit 0f8da7a.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please ensure your pull request adheres to the following guidelines:
Related Issues
Thanks for contributing!