[CORE-119212] - Add/fix pdb for controllers #94
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cawright-rh
reviewed
Dec 20, 2024
cawright-rh
approved these changes
Dec 20, 2024
hvan
commented
Jan 9, 2025
| } | ||
| } | ||
|
|
||
| func expectKafkaPDBZK(ctx context.Context, kafkaCluster *v1beta1.KafkaCluster) { |
There was a problem hiding this comment.
Separate test for ZK and KRaft
hvan
commented
Jan 9, 2025
| }).WithTimeout(1000).Should(MatchError(fmt.Sprintf("poddisruptionbudgets.policy \"%s-controller-pdb\" not found", kafkaCluster.Name))) | ||
| } | ||
|
|
||
| func expectKafkaPDBKraft(ctx context.Context, kafkaCluster *v1beta1.KafkaCluster) { |
There was a problem hiding this comment.
Separate test for ZK and KRaft
dvaseekara
approved these changes
Jan 10, 2025
| minAvailable) | ||
| } | ||
|
|
||
| func (r *Reconciler) podDisruptionBudgetControllers(log logr.Logger) (runtime.Object, error) { |
There was a problem hiding this comment.
Do we need to add some functional tests for the new functions?
| }, | ||
| }, | ||
| }, nil | ||
| } | ||
|
|
||
| func (r *Reconciler) getControllerCount() (int, error) { |
|
|
||
| // Calculate minAvailable as max between brokerCount - 1 (so we only allow 1 controller to be disrupted) | ||
| // and 1 (case when there is only 1 controller) | ||
| func (r *Reconciler) computeControllerMinAvailable() (intstr.IntOrString, error) { |
There was a problem hiding this comment.
See above note about functional tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Please provide a meaningful description of what this change will do, or is for. Bonus points for including links to
related issues, other PRs, or technical references.
Note that by not including a description, you are asking reviewers to do extra work to understand the context of this
change, which may lead to your PR taking much longer to review, or result in it not being reviewed at all.
Type of Change
Checklist