Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ACNA-3397 - exclude web-export and raw-http properties in action, allow web property to be boolean #38

Merged
merged 4 commits into from
Dec 12, 2024

Conversation

shazron
Copy link
Member

@shazron shazron commented Dec 10, 2024

  1. Exclude web-export and raw-http properties from action config (only should be in action annotations)
  2. Add web property in action to also be boolean type (was just string)

How Has This Been Tested?

  • npm test

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Sorry, something went wrong.

… that should not be in the action config (only action annotations)
Copy link

codecov bot commented Dec 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (002f3a3) to head (473d0d4).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##            master       #38   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            1         1           
  Lines          260       260           
  Branches        80        80           
=========================================
  Hits           260       260           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

… will make more sense
@shazron shazron changed the title fix: ACNA-3397 - add web-export and raw-http properties as properties that should not be in the action config (only action annotations) fix: ACNA-3397 - exclude web-export and raw-http properties in action, allow web property to be boolean Dec 10, 2024
@shazron shazron changed the title fix: ACNA-3397 - exclude web-export and raw-http properties in action, allow web property to be boolean fix: ACNA-3397 - exclude web-export and raw-http properties in action, allow web property to be boolean Dec 10, 2024
@moritzraho
Copy link
Member

moritzraho commented Dec 11, 2024

Exclude web-export and raw-http properties from action config (only should be in action annotations)

sounds like a breaking change? or are those not parsed downstream anyways?

@shazron
Copy link
Member Author

shazron commented Dec 11, 2024

Exclude web-export and raw-http properties from action config (only should be in action annotations)

sounds like a breaking change? or are those not parsed downstream anyways?

not really a breaking change, but a bug fix to properly apply the spec. We were not validating the config on deploy anyway: adobe/aio-cli-plugin-app#826

@moritzraho
Copy link
Member

lgtm then!

@shazron shazron merged commit ccc67a9 into master Dec 12, 2024
8 checks passed
@shazron shazron deleted the story/ACNA-3397 branch December 12, 2024 08:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants