Issue 493 filter events by animal #499
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cookeac
reviewed
Nov 27, 2024
There was a problem hiding this comment.
We discussed this at the group meeting Nov 27 2004. We preferred this approach (using animal identity as an optional filter).
- To be consistent with other filters, it would appear that
animal-schemeandanimal-idshould be the filter parameters. However, I understand thatanimal-schemeis not completely obvious, which is why you have coded it asanimal-identifier-scheme. Would you consideranimal-id-scheme? - We need some documentation so that people know both values must be provided for the filter to work.
|
I do have no problems with "animal-id-scheme" |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.