Define position observations #430
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Define position observation events (group and animal) that allow you to record that an animal (or group/mob) was seen (observed) at a given named position or geospatial location. Resolves adewg#383
Merged
Add the icarSortingSiteResource identifier (site) to position observations, so you can record a position observation to confirm that an animal has been sorted into that site.
|
Updated position observations to support the site ID from sorting sites. See also #456. |
AndreasSchultzGEA
approved these changes
May 2, 2024
| "type": "string", | ||
| "description": "Identifier for a sorting site (icarSortingSiteResource) for this position." | ||
| }, | ||
| "geometry": { |
There was a problem hiding this comment.
I was a little bit worried how this property will be generated in the c# code, but seems that there is nothing special about it. Works fine.
AlexeyHardCode
approved these changes
May 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Define position observation events (group and animal) that allow you to record that an animal (or group/mob) was seen (observed) at a given named position or geospatial location.
Resolves #383
Note: #383 talked about these as "location" events originally, but this could cause confusion with Location = Farm/Holding.
In this context we mean a barn, pen, field, paddock, or other named area, or a geospatial location (a polygon or a point such as a lat/long position).
Note: This PR references the GeoJSON
geometryobject defined at https://geojson.org/schema/Geometry.jsonThis currently causes an OAS3 parsing error, because the GeoJSON schema uses the $schema and #id keywords that are not supported in OpenAPI 3.0. They will be supported when we upgrade to OpenAPI 3.1 and the error should disappear.