Type classification #269
Merged
Type classification #269
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
created url, and collection - resource for the time being a copy of conformation scores (work in progress)
got an error - don't know if this will help
changed version
added a trait group to the comformation score resource
the trait group definition
missing bracket
Added a Type for the conformation score and used that in the typeCalssificationResource
added the composite tratits to the enum
improved swaggeer documentation
use the same resource for conformation scores
move conformation score to a reusable type
trying to use allOf
cookeac
reviewed
Dec 7, 2021
| } | ||
| } | ||
| } | ||
| }, |
There was a problem hiding this comment.
Could we also have a /batches/ URL for posting batches of type classifications? I don't think we have this yet unless I've missed it.
There was a problem hiding this comment.
It's not there yet. I propose to tackle this in a seperate action - extra pull request.
cookeac
approved these changes
Dec 13, 2021
cookeac
requested review from
AlexeyHardCode and
cvigorsICBF
and removed request for
ahokkonen
AlexeyHardCode
approved these changes
Dec 23, 2021
AlexeyHardCode
approved these changes
Dec 23, 2021
AlexeyHardCode
approved these changes
Dec 23, 2021
AlexeyHardCode
approved these changes
Dec 23, 2021
Closed
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I solved the breaking change - needs to be checked if code generation is going ok