Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove DoNotBreed from animal #213

Closed
dirbSEGES opened this issue Apr 9, 2021 · 5 comments · Fixed by #231
Closed

Remove DoNotBreed from animal #213

dirbSEGES opened this issue Apr 9, 2021 · 5 comments · Fixed by #231

Comments

@dirbSEGES
Copy link

Hi,

Do you have any suggestion how to remove a DoNotBreed label from an animal?

When a client are using the DoNotBreed ressource, it sets a DNB label to an animal, but the ressource, as I understand, can not remove it again?

@cookeac
Copy link
Collaborator

cookeac commented May 6, 2021

Maybe this should be a BreedControl event, so you can set it to Do Not Breed, or Allow Breeding.
@erwinspeybroeck to investigate how they are using this event.

@dirbSEGES
Copy link
Author

We like the idea of a BreedControl event.

@erwinspeybroeck
Copy link
Collaborator

We use a DELETE event to switch from the status do not breed to allow breeding.
If someone would need history to keep track of the changes, it can be done by storing the delete event to keep track of the changed status of the animal

@cookeac
Copy link
Collaborator

cookeac commented Jul 29, 2021

Proposing that we add a boolean doNotBreed attribute to the icarReproDoNotBreedEventResource. This allows an observer to turn off the reproductiveStatus "DoNotBreed". For backwards compatibility, this will be nullable and true by default, so that it must be explicitly specified as false to clear the DoNotBreed status.

cookeac added a commit to cookeac/ICAR that referenced this issue Jul 29, 2021
Added a boolean, nullable (default true) *doNotBreed* to document toggling the reproductive status "Do Not Breed" on or off.
Fixes adewg#213
@dirbSEGES
Copy link
Author

Fine solution :-)

@cookeac cookeac closed this as completed Aug 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants