Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: Test output (fixes #38) #39

Merged
merged 2 commits into from
Mar 3, 2025
Merged

Fix: Test output (fixes #38) #39

merged 2 commits into from
Mar 3, 2025

Conversation

oliverfoster
Copy link
Member

@oliverfoster oliverfoster commented Feb 24, 2025 •
edited
Loading

Fix

  • Test execution label is clearer
  • Summary of changes correctly prints for each unique_id when _type is missing from content
  • Summary of changes reports no changes rather than a blank table
  • Defaults were added for missing context elements
  • Deep clone test content to prevent mutation of data passed by refence

@oliverfoster oliverfoster self-assigned this Feb 24, 2025
joe-allen-89
joe-allen-89 approved these changes Feb 25, 2025
View reviewed changes
Copy link
Contributor

@joe-allen-89 joe-allen-89 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Working nicely with a tweek to the migration task.

@oliverfoster
Copy link
Member Author

I think I did that in the outstanding framework pr at adaptlearning/adapt_framework@8ca9917

adaptlearning/adapt_framework#3633

@joe-allen-89
Copy link
Contributor

You did, I just hadn't pulled the updated branch apparently.

@oliverfoster oliverfoster merged commit 360f859 into master Mar 3, 2025
@oliverfoster oliverfoster deleted the issue/38 branch March 3, 2025 15:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joe-allen-89 joe-allen-89 joe-allen-89 approved these changes

Assignees

@oliverfoster oliverfoster

Labels
bug
Projects
adapt_framework: The TODO Board
Status: Recently Released
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@oliverfoster @joe-allen-89