New: Migration Scripts (fixes #217) #218
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oliverfoster
requested changes
Mar 10, 2025
|
|
||
| mutateContent('adapt-contrib-slider - add slider._correctAnswer', async () => { | ||
| sliders.forEach(slider => { | ||
| const newValue = slider._correctAnswer?.toString() || ''; |
There was a problem hiding this comment.
This looks to be an explicit conversion to the string data type. I assume it went from number to string at some point?
You can make this clearer to read by doing the type conversion at the end of the evaluation.
Suggested change
| const newValue = slider._correctAnswer?.toString() || ''; | |
| const newValue = String(slider._correctAnswer ?? ''); |
|
|
||
| updatePlugin('adapt-contrib-slider - update to v2.1.0', { name: 'adapt-contrib-slider', version: '2.1.0', framework: '>=2.0.0' }); | ||
|
|
||
| testSuccessWhere('non/configured slider component with empty course', { |
There was a problem hiding this comment.
The description here doesn't make sense. The migration script does not modify or rely on the course object.
|
|
||
| mutateContent('adapt-contrib-slider - remove slider._feedback._partlyCorrect', async () => { | ||
| sliders.forEach(slider => { | ||
| delete slider._feedback._partlyCorrect; |
There was a problem hiding this comment.
A test with no _feedback object will fail.
{ _id: 'c-115', _component: 'slider' },
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New
Testing
Test using this branch of the Adapt Framework which includes the scripts that handle the migration.
adaptlearning/adapt_framework#3633