Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: Clarify _showPageCompletion functionality (fixes #215) #219

Merged
merged 1 commit into from
May 30, 2024
Merged

Fix: Clarify _showPageCompletion functionality (fixes #215) #219

merged 1 commit into from
May 30, 2024

Conversation

swashbuck
Copy link
Contributor

Fix #215

Fix

  • Clarifies how _showPageCompletion functionality works in the schemas.
  • Readme: Add default value for _showPageCompletion

@swashbuck swashbuck self-assigned this May 16, 2024
cahirodoherty-learningpool
cahirodoherty-learningpool approved these changes May 17, 2024
View reviewed changes
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👀

kirsty-hames
kirsty-hames approved these changes May 30, 2024
View reviewed changes
Copy link
Contributor

@kirsty-hames kirsty-hames left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👀

@kirsty-hames kirsty-hames merged commit 060e88c into master May 30, 2024
1 check passed
@kirsty-hames kirsty-hames deleted the issue/215 branch May 30, 2024 08:45
github-actions bot pushed a commit that referenced this pull request May 30, 2024
@semantic-release-bot
Chore(release): 7.6.3 [skip ci]
b167625 
## [7.6.3](v7.6.2...v7.6.3) (2024-05-30)

### Fix

* Clarify _showPageCompletion functionality (fixes #215) #219 ([060e88c](060e88c)), closes [#215](#215) [#219](#219)
@github-actions GitHub Actions
Copy link

🎉 This PR is included in version 7.6.3 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kirsty-hames kirsty-hames

@oliverfoster oliverfoster

@cahirodoherty-learningpool cahirodoherty-learningpool

Assignees

@swashbuck swashbuck

Labels
documentation released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

AAT: Clarify how _showPageCompletion works
4 participants
@swashbuck @kirsty-hames @oliverfoster @cahirodoherty-learningpool