Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Chore: e2e tests on page level progress extension (Issue/207) #214

Merged
merged 9 commits into from
Apr 22, 2024
Merged

Chore: e2e tests on page level progress extension (Issue/207) #214

merged 9 commits into from
Apr 22, 2024

Conversation

lemmyadams
Copy link
Contributor

Addresses #207

Adds basic level of e2e test for now, checking mainly if the bar appears when it should

@lemmyadams lemmyadams self-assigned this Mar 21, 2024
lemmyadams and others added 4 commits March 22, 2024 12:19
@lemmyadams @cahirodoherty-learningpool
Update test/e2e/pageLevelProgress.cy.js
0ca9cc5 
Co-authored-by: Cahir O'Doherty <41006337+cahirodoherty-learningpool@users.noreply.github.com>
@lemmyadams @cahirodoherty-learningpool
Update test/e2e/pageLevelProgress.cy.js
e76dd63 
Co-authored-by: Cahir O'Doherty <41006337+cahirodoherty-learningpool@users.noreply.github.com>
@lemmyadams @cahirodoherty-learningpool
Update test/e2e/pageLevelProgress.cy.js
f50c7d3 
Co-authored-by: Cahir O'Doherty <41006337+cahirodoherty-learningpool@users.noreply.github.com>
@lemmyadams @cahirodoherty-learningpool
Update test/e2e/pageLevelProgress.cy.js
d286c2a 
Co-authored-by: Cahir O'Doherty <41006337+cahirodoherty-learningpool@users.noreply.github.com>
lemmyadams and others added 2 commits March 22, 2024 13:41
@lemmyadams @cahirodoherty-learningpool
Update test/e2e/pageLevelProgress.cy.js
d3f264d 
Co-authored-by: Cahir O'Doherty <41006337+cahirodoherty-learningpool@users.noreply.github.com>
@lemmyadams @cahirodoherty-learningpool
Update test/e2e/pageLevelProgress.cy.js
f3dca9a 
Co-authored-by: Cahir O'Doherty <41006337+cahirodoherty-learningpool@users.noreply.github.com>
cahirodoherty-learningpool
cahirodoherty-learningpool approved these changes Mar 22, 2024
View reviewed changes
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👀

joe-allen-89
joe-allen-89 approved these changes Apr 16, 2024
View reviewed changes
Copy link
Contributor

@joe-allen-89 joe-allen-89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@joe-allen-89 joe-allen-89 merged commit 3d7c2d0 into master Apr 22, 2024
@joe-allen-89 joe-allen-89 deleted the issue/207 branch April 22, 2024 11:13
github-actions bot pushed a commit that referenced this pull request May 3, 2024
@semantic-release-bot
Chore(release): 7.6.0 [skip ci]
7b266ad 
# [7.6.0](v7.5.1...v7.6.0) (2024-05-03)

### Chore

* e2e tests on page level progress extension (Issue/207) (#214) ([3d7c2d0](3d7c2d0)), closes [#214](#214)

### New

* Added type selector to drawer item button (#216) ([6b74cbb](6b74cbb)), closes [#216](#216)
@github-actions GitHub Actions
Copy link

github-actions bot commented May 3, 2024

🎉 This PR is included in version 7.6.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cahirodoherty-learningpool cahirodoherty-learningpool cahirodoherty-learningpool approved these changes

@ethan-lp ethan-lp ethan-lp approved these changes

@joe-allen-89 joe-allen-89 joe-allen-89 approved these changes

Assignees

@lemmyadams lemmyadams

Labels
enhancement released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@lemmyadams @cahirodoherty-learningpool @ethan-lp @joe-allen-89