-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
_showAtCourseLevel setting isn't displaying correctly #247
Comments
The previous pr meant that the sub content objects would only show when their parent was the active content object. Is that behaviour broken? |
Previous to the version in the pevious PR (one version before it), all contentObjects would show (aside from menus and the components from non-current pages), so I would expect that when But yes, it is breaking a course structure with grouped menu objects. |
So it's not showing the sub content objects because the group content object is not navigable and will never be the current page? |
Directly sending you a link to a demonstration. My theory is that #212 wasn't the appropriate fix for the issue at the time and that the duplication of contentObjects in the drawer was fixed elsewhere. The PR I have submitted for this issue produces a version of pageLevelProgress that aligns with my expectations on how it should work. |
There are course configurations where the plp should show: The current code does not allow for option 2, whereas option 2 used to be the default. A secondary problem arises, in that if a sub-menu contentobject is a group (as per box menu) and not meant to be rendered as a sub-menu, then the plp will incorrectly navigate to a sub-menu rendering of the group when a group is clicked. This is primarily because the router treats all contentobjects as the main contentobject and it cannot treat contentobjects as sub-parts of their parent. The only code which is currently aware that it should treat sub-menus as groups is the box menu, which causes issues to arise in the plp and router. |
Subject of the issue/enhancement/features
#212 introduced a few issues with content visibility in the drawer.
Your environment
Steps to reproduce
_showAtCourseLevel.
Expected behaviour
With
_showAtCourseLevel
enabled, the drawer should behave exactly as it does when the setting is disabled, with the addition of other available pages appearing.Actual behaviour
Additional context
The course-level item is visible, along with any contentObjects that are direct descendants of the course. However, deeper nested pages and content aren’t shown.
Screenshot
The text was updated successfully, but these errors were encountered: