Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

calculatePercentage issue for components with items #228

Closed
swashbuck opened this issue Jun 4, 2024 · 1 comment · Fixed by #229
Closed

calculatePercentage issue for components with items #228

swashbuck opened this issue Jun 4, 2024 · 1 comment · Fixed by #229
Assignees
@swashbuck
Labels
bug released

Comments

@swashbuck
Copy link
Contributor

swashbuck commented Jun 4, 2024 •
edited
Loading

Subject of the issue

In #221, the progress of presentation components with items are shown incrementally. That is, if 1 of 3 Narrative stages are completed, the PLP progress bar for the component will be 33% full.

This is breaking the "Complete page" option in Dev Tools. Presentation components with items are not shown in the PLP drawer as being fully completed. However, it does appear that the overall page is marked as completed.

Your environment

  • PLP 7.7.0
  • Dev Tools 3.5.4

Steps to reproduce

  1. In the vanilla p101 build, go to Presentation Components
  2. Open the Dev Tools drawer and select "Complete page"

Result

Components with items (e.g. Narrative) are shown as partially complete.

PLP
@swashbuck swashbuck added the bug label Jun 4, 2024
@swashbuck swashbuck self-assigned this Jun 4, 2024
@swashbuck swashbuck moved this from New to Assigned in adapt_framework: The TODO Board Jun 4, 2024
This was referenced Jun 4, 2024
Merged
Closed
@swashbuck swashbuck moved this from Assigned to Needs Reviewing in adapt_framework: The TODO Board Jun 4, 2024
joe-allen-89 pushed a commit that referenced this issue Jun 7, 2024
@swashbuck @oliverfoster
Fix: Return correct calculation for presentation components with items (
b327bb7 
fixes #228) (#229)

* Fix incorrect calculation for presentation components with items

* Update js/PageLevelProgressIndicatorView.js

Co-authored-by: Oliver Foster <oliver.foster@kineo.com>

* Update js/PageLevelProgressIndicatorView.js

Co-authored-by: Oliver Foster <oliver.foster@kineo.com>

* Update js/PageLevelProgressIndicatorView.js

Co-authored-by: Oliver Foster <oliver.foster@kineo.com>

---------

Co-authored-by: Oliver Foster <oliver.foster@kineo.com>
@github-project-automation github-project-automation bot moved this from Needs Reviewing to Recently Released in adapt_framework: The TODO Board Jun 7, 2024
github-actions bot pushed a commit that referenced this issue Jun 7, 2024
@semantic-release-bot
Chore(release): 7.8.1 [skip ci]
ebd565b 
## [7.8.1](v7.8.0...v7.8.1) (2024-06-07)

### Fix

* Return correct calculation for presentation components with items (fixes #228) (#229) ([b327bb7](b327bb7)), closes [#228](#228) [#229](#229)
@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 7, 2024

🎉 This issue has been resolved in version 7.8.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@swashbuck swashbuck

Labels
bug released
Projects
None yet
Milestone
No milestone
1 participant
@swashbuck