Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: Support level course in a11y.ariaLevel (fixes #453) #506

Merged
merged 1 commit into from
Mar 25, 2024
Merged

Fix: Support level course in a11y.ariaLevel (fixes #453) #506

merged 1 commit into from
Mar 25, 2024

Conversation

oliverfoster
Copy link
Member

fixes #453

Fix

  • Moved course to menu conversion back in the execution hierarchy to allow a11y.ariaLevel to convert course type to menu instead of relying on headingView to do it.

@oliverfoster oliverfoster self-assigned this Mar 15, 2024
swashbuck
swashbuck approved these changes Mar 15, 2024
View reviewed changes
Copy link
Contributor

@swashbuck swashbuck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

cahirodoherty-learningpool
cahirodoherty-learningpool approved these changes Mar 18, 2024
View reviewed changes
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👀

joe-allen-89
joe-allen-89 approved these changes Mar 25, 2024
View reviewed changes
Copy link
Contributor

@joe-allen-89 joe-allen-89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@joe-allen-89 joe-allen-89 merged commit 32cfef6 into master Mar 25, 2024
1 check passed
@joe-allen-89 joe-allen-89 deleted the issue/453 branch March 25, 2024 11:20
github-actions bot pushed a commit that referenced this pull request Mar 25, 2024
@semantic-release-bot
Chore(release): 6.46.1
8a11ea3 
## [6.46.1](v6.46.0...v6.46.1) (2024-03-25)

### Fix

* Support level course in a11y.ariaLevel (fixes #453) (#506) ([32cfef6](32cfef6)), closes [#453](#453) [#506](#506)
@oliverfoster
Copy link
Member Author

🎉 This PR is included in version 6.46.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@swashbuck swashbuck swashbuck approved these changes

@cahirodoherty-learningpool cahirodoherty-learningpool cahirodoherty-learningpool approved these changes

@joe-allen-89 joe-allen-89 joe-allen-89 approved these changes

Assignees

@oliverfoster oliverfoster

Labels
bug released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

calculateLevel issue when returning to a completed course
4 participants
@oliverfoster @swashbuck @cahirodoherty-learningpool @joe-allen-89