Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Defensive code for poor state restoration #507

Closed
oliverfoster opened this issue Mar 15, 2024 · 1 comment · Fixed by #508
Closed

Defensive code for poor state restoration #507

oliverfoster opened this issue Mar 15, 2024 · 1 comment · Fixed by #508
Assignees
@oliverfoster
Labels
bug released

Comments

@oliverfoster
Copy link
Member

oliverfoster commented Mar 15, 2024 •
edited
Loading

Subject of the issue

There are some instances where the code assumes object properties have values but where the code should return early when the values are missing and the code does currently not return early.
@oliverfoster oliverfoster self-assigned this Mar 15, 2024
@oliverfoster oliverfoster mentioned this issue Mar 15, 2024
Merged
@oliverfoster oliverfoster moved this from New to Needs Reviewing in adapt_framework: The TODO Board Mar 15, 2024
joe-allen-89 pushed a commit that referenced this issue Mar 18, 2024
@oliverfoster
Fix: Missing object property lookup restoreUserAnswers, getFeedback, …
e84fed4 
…ItemsQuestionModel (fixes #507) (#508)

* Fix: missing _userAnswer in restoreUserAnswers

* Fix: getFeedback missing activeItem
@github-project-automation github-project-automation bot moved this from Needs Reviewing to Recently Released in adapt_framework: The TODO Board Mar 18, 2024
github-actions bot pushed a commit that referenced this issue Mar 18, 2024
@semantic-release-bot
Chore(release): 6.45.8
b67304e 
## [6.45.8](v6.45.7...v6.45.8) (2024-03-18)

### Fix

* Missing object property lookup restoreUserAnswers, getFeedback, ItemsQuestionModel (fixes #507) (#508) ([e84fed4](e84fed4)), closes [#507](#507) [#508](#508)
@oliverfoster
Copy link
Member Author

🎉 This issue has been resolved in version 6.45.8 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@oliverfoster oliverfoster

Labels
bug released
Projects
None yet
Milestone
No milestone
1 participant
@oliverfoster