New: Migration Scripts (fixes #158) #159
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chris-steele
requested changes
Jan 22, 2025
Waiting for confirmation.
|
@chris-steele, appreciate the early review. I am requesting another review from you and have officially turned this PR to 'Needs Reviewing'. |
|
I have tested the migration itself and everything has tested as expected. |
oliverfoster
requested changes
Mar 5, 2025
oliverfoster
reviewed
Mar 5, 2025
oliverfoster
reviewed
Mar 5, 2025
|
|
||
| mutateContent('adapt-contrib-accordion - add accordion._items._classes attribute', async () => { | ||
| accordions.forEach(accordion => { | ||
| accordion._items.forEach(item => { |
There was a problem hiding this comment.
A test with missing _items will error here.
{ _id: 'c-110', _component: 'accordion' }Is this ok?
|
|
||
| mutateContent('adapt-contrib-accordion - add accordion._items._classes attribute', async () => { | ||
| accordions.forEach(accordion => { | ||
| accordion._items.forEach(item => { |
There was a problem hiding this comment.
It could be as simple as optional chaining throughout?
Suggested change
| accordion._items.forEach(item => { | |
| accordion._items?.forEach(item => { |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New
Testing
Test using this branch of the Adapt Framework which includes the scripts that handle the migration.
adaptlearning/adapt_framework#3633