Persist updates between server restarts #1903
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joka921
requested changes
Mar 26, 2025
src/index/DeltaTriples.cpp
Outdated
| ad_utility::serializeIds( | ||
| tempPath, localVocab_, | ||
| std::array{toRange(triplesDeleted_), toRange(triplesInserted_)}); | ||
| std::filesystem::rename(tempPath, storagePath); |
There was a problem hiding this comment.
do something if the renaming fails.
Comment on lines
+72
to
+73
| AD_CONTRACT_CHECK(vocab.numSets() == 1); | ||
| const auto& words = vocab.primaryWordSet(); |
There was a problem hiding this comment.
Can be (at least in a TODO) extended to more than one set.
hannahbast
changed the title
hannahbast
changed the title
|
@RobinTF Thanks a lot for this. I had a look at this together with @joka921 and it worked in principle, great! I wrote a description above, please check. Here are some issues that should be addressed before this can be merged:
|
Signed-off-by: Johannes Kalmbach <johannes.kalmbach@gmail.com>
Signed-off-by: Johannes Kalmbach <johannes.kalmbach@gmail.com>
Signed-off-by: Johannes Kalmbach <johannes.kalmbach@gmail.com>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1903 +/- ##
==========================================
- Coverage 90.56% 90.56% -0.01%
==========================================
Files 414 415 +1
Lines 40100 40284 +184
Branches 4536 4554 +18
==========================================
+ Hits 36318 36484 +166
- Misses 2427 2442 +15
- Partials 1355 1358 +3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
hannahbast
pushed a commit
to ad-freiburg/qlever-control
that referenced
this pull request
Mar 27, 2025
This is the accompanying change for the `persists-updates` option introduced by ad-freiburg/qlever#1903
Signed-off-by: Johannes Kalmbach <johannes.kalmbach@gmail.com>
joka921
requested changes
Mar 31, 2025
Signed-off-by: Johannes Kalmbach <johannes.kalmbach@gmail.com>
Signed-off-by: Johannes Kalmbach <johannes.kalmbach@gmail.com>
Conformance check passed ✅No test result changes. |
hannahbast
approved these changes
Mar 31, 2025
|
hannahbast
added a commit
to ad-freiburg/qlever-control
that referenced
this pull request
Mar 31, 2025
This is the accompanying change for the `persists-updates` option introduced by ad-freiburg/qlever#1903
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So far, delta triples due to updates were lost when the server was restarted. This change introduces an option
--persist-updates, which has the following effect:After each update, the complete set of delta triples (inserted and deleted) as well as the associated local vocabulary is written to disk, to a file
<name>.update-triples, where<name>is the basename of the index files.When restarting the server, that file is read and the update triples are processed in such a way that the server ends up in the same state it was in when that file was written.
When restarting the server without the option
--persist-updatesor if there is no file<name>.update-triples, the server is in the same state it would be in if there are no update triples (or after the commandclear-delta-triples).NOTE: This is a first implementation, which provides the basic functionality. After each update, the complete set of delta triples is written, even if that update inserted or removed only few triples relative to the previous updates. If an error occurs during an update operation, the server state is still undefined and one effectively loses all delta triples. This is work for future PRs.