Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Labeler removes label that is already set by Dependabot #442

Closed
efb4f5ff-1298-471a-8973-3d47447115dc opened this issue Oct 3, 2022 · 5 comments
Closed

Labeler removes label that is already set by Dependabot #442

efb4f5ff-1298-471a-8973-3d47447115dc opened this issue Oct 3, 2022 · 5 comments

Comments

@efb4f5ff-1298-471a-8973-3d47447115dc
Copy link

efb4f5ff-1298-471a-8973-3d47447115dc commented Oct 3, 2022 •
edited
Loading

This happens on:

Related files:

Is this a configuration error on my end? The intended purpose of setting the dependencies label through the labeler workflow is when we update a dependency manually instead of using dependabot.

Something to note is that the bot only removes the dependencies label and not the waiting for review label even though the label is used in both workflows.
Merged
@MaksimZhukov
Copy link
Contributor

Hello @efb4f5ff-1298-471a-8973-3d47447115dc !
Thank you for reporting this!

Unfortunately, there is a bug in the labeler action and your labels are removed due to it. The sync-labels input does not work properly. By default, its value is true actually. In this case, the labeler action will remove the label from the PR if the label globs do not match the files modified in scope of the PR.

Here is a list of possible solutions:

  1. Add globs to match files that may be changed by Dependabot
  2. Use different labels
  3. Use the following workaround until the bug is fixed:
sync-labels: ''

Sorry for the inconvenience!

@ZainRizvi ZainRizvi mentioned this issue Oct 31, 2022
Closed
@plmercereau plmercereau mentioned this issue Dec 2, 2022
Merged
@MaksimZhukov
Copy link
Contributor

I’m closing the issue. Please let us know if you have any concerns.

@efb4f5ff-1298-471a-8973-3d47447115dc
Copy link
Author

Hi @adam-azarchs, how should i configure the workflow after ur pr has been merged to address this issue?

Will the bot remove the label after ur pr has been merged or not?

@adam-azarchs
Copy link
Contributor

It will not. And if you're using the workaround mentioned above, the action will fail until you remove it, which is why it'll be a major version bump.

@efb4f5ff-1298-471a-8973-3d47447115dc
Copy link
Author

efb4f5ff-1298-471a-8973-3d47447115dc commented Feb 1, 2023 •
edited
Loading

It will not. And if you're using the workaround mentioned above, the action will fail until you remove it, which is why it'll be a major version bump.

We'll just wait for the next version then. We are not using the workaround.

@danyeaw danyeaw mentioned this issue Feb 13, 2023
Merged
8 tasks
@drfloob drfloob mentioned this issue Mar 3, 2023
Merged
drfloob added a commit to grpc/grpc that referenced this issue Mar 3, 2023
@drfloob
[codehealth] Prevent the labeler workflow from removing labels (#32542)
b5fc93a 
It seems as if we ran into this bug
actions/labeler#442 on at least one PR
#32515. This PR utilizes the suggested
workaround until we can upgrade to a new major version release of
actions/labeler.
@luisorbaiceta luisorbaiceta mentioned this issue Apr 5, 2023
Merged
1 task
XuanWang-Amos pushed a commit to XuanWang-Amos/grpc that referenced this issue May 1, 2023
@drfloob @XuanWang-Amos
[codehealth] Prevent the labeler workflow from removing labels (grpc#…
a8c4238 
…32542)

It seems as if we ran into this bug
actions/labeler#442 on at least one PR
grpc#32515. This PR utilizes the suggested
workaround until we can upgrade to a new major version release of
actions/labeler.
wanlin31 pushed a commit to grpc/grpc that referenced this issue May 18, 2023
@drfloob @wanlin31
[codehealth] Prevent the labeler workflow from removing labels (#32542)
1446b8a 
It seems as if we ran into this bug
actions/labeler#442 on at least one PR
#32515. This PR utilizes the suggested
workaround until we can upgrade to a new major version release of
actions/labeler.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@adam-azarchs @MaksimZhukov @efb4f5ff-1298-471a-8973-3d47447115dc