-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
adapt s2 importer to work without Google BigQuery #295
Merged
anikaweinmann
merged 9 commits into
actinia-org:main
from
griembauer:issue_242_s2_importer
Mar 21, 2022
Merged
adapt s2 importer to work without Google BigQuery #295
anikaweinmann
merged 9 commits into
actinia-org:main
from
griembauer:issue_242_s2_importer
Mar 21, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
neteler
reviewed
Jan 17, 2022
neteler
reviewed
Jan 17, 2022
anikaweinmann
approved these changes
Jan 18, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you.
This was
linked to
issues
Feb 3, 2022
Closed
This was referenced Mar 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adapts the actinia
importer
process for the importing of Sentinel-2 data. Sentinel-2 data (indicated by a scene-ID) can now be imported directly from Google Cloud Storage without providing any credentials usingi.sentinel.download
andi.sentinel.import
in the background. This PR currently uses the standard implementation of theimporter
: eachimport_description
can be used to import exactly ONE raster map. For Sentinel-2 data, this means that each band has to be specified individually.Note: The current implementation (query via Google Cloud BigQuery interface etc.) is not removed in this PR, the new functionality without login is simply added.
perspective TODOs:
importer
. This still needs to be implemented.i.sentinel.import
reprojects the map if it does not match the current projection. This may interfere with 0-values, that should be treated as NULL-values and removed viar.null
ori.zero2null
. This problem should probably be solved inr.import
i.sentinel.download
such that it can directly download individual bands (and required metadata) instead of the entire scene, (and maybe even cut it to the current region)i.sentinel.coverage
+t.sentinel.import
). This is currently implemented with the BigQuery approach and should be replaced.Example PC: