stac variable and command generation into actinia -- AssertionError raised #273
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joaherrerama
commented
Nov 11, 2021
mmacata
reviewed
Nov 16, 2021
There was a problem hiding this comment.
Nice entrypoint for STAC!
I don't approve yet as we like to break the object orientation here. Instead of stac_commands = self._get_stac_import_download_commands(entry) it would be cool to import and call a separated STAC module (for now included in actinia_core) like stac_commands = get_stac_import_download_commands(entry, self.config, self.temp_file_path, self.message_logger, self.send_resource_update)
It might look a bit funny and your approach would definitely fit better to the current actinia implementation but the appoach I suggest here fits better to what we plant to change in the future.
|
I think, we can close this pull request and redirect it to #275 right? |
|
If it is contained there, then yes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request, will recognize the commands required for the importation of STAC variables stored in the STAC instances throughout the STAC plugin