-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added OpenSearch support #9
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adee57b
to
461e7a5
Compare
9bd01a3
to
290a767
Compare
1. Moved ElasticSearch-specific adapter code to dedicated file 2. Added OpenSearch adapter with support insert, search and count
1. Created interface for ElasticSearch-based adapters for index management 2. Moved ElasticSearch index management code to ElasticSearch adapter
1. Added index management to OpenSearch adapter: a. ISM policies creation, search and deletion b. Components templates creation and deletion c. Index templates createion and deletion d. Data Stream deletion
03b555e
to
2339296
Compare
1. Actualized acronis-db-bench examples of tests launch according to new CLI params 2. Added acronis-db-bench examples of launching tests towards to ElasticSearch and OpenSearch
2339296
to
6a43e40
Compare
perfguru87
approved these changes
Oct 16, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can probably fix it in separate PR
```bash | ||
go install acronis-db-bench | ||
acronis-db-bench --driver <database_driver> --dsn "<data_source_name>" ... | ||
acronis-db-bench --connection-string "<connection_string>" ... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we remove --dsn and --driver?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.