SMBus Companion Devices #63
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Good to go, this has been more reliable on my end compared to the old system. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support to ApplePS2SynapticTouchpad to create SMBus companion devices. This means that VoodooRMI will not start until VoodooPS2 is done probing and detects that the touchpad has SMBus support. A new service (ApplePS2SMBusDevice) is added to prevent other PS/2 drivers attaching and using the PS/2 port on these touchpads.
The case without VoodooSMBus should still work, as VoodooPS2 checks IOResources before attempting to use SMBus for the Synaptic touchpad. The only downside is that there is no way to recover from VoodooRMI failing to start. I originally had the call to create the SMBus companion device in
probeinstead ofstart, but other PS/2 drivers probing would break VoodooRMI due to both drivers trying to use the touchpad at the same time.This does work (unlike my other attempts), just need some time to do cleanup and to test.
Replaces #59
Companion PRs:
VoodooSMBus: 1Revenger1/VoodooSMBus#4
VoodooRMI: VoodooSMBus/VoodooRMI#183