Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Separate Layout Parsing from Window Management #38

Merged
merged 12 commits into from
Jun 17, 2021

Conversation

abstractlyZach
Copy link
Owner

@abstractlyZach abstractlyZach commented Jun 17, 2021

By separating layout parsing from window management, we can prepare for window resizing and keep it separate from window spawning. It'll be easier to test and more decoupled

@codecov-commenter
Copy link

Codecov Report

Merging #38 (12ce2e4) into main (15b426d) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##              main       #38   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            9         9           
  Lines          214       217    +3     
  Branches        22        24    +2     
=========================================
+ Hits           214       217    +3     
Impacted Files Coverage Δ
src/magic_tiler/magic_tiler.py 100.00% <100.00%> (ø)
src/magic_tiler/utils/dtos.py 100.00% <100.00%> (ø)
src/magic_tiler/utils/layouts.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 15b426d...12ce2e4. Read the comment docs.

@abstractlyZach abstractlyZach added the refactoring changes in design without changing functionality label Jun 17, 2021
@abstractlyZach abstractlyZach merged commit e33b747 into main Jun 17, 2021
@abstractlyZach abstractlyZach deleted the separate-layout-parsing-from-management branch June 17, 2021 13:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactoring changes in design without changing functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants