Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use marks #15

Merged
merged 7 commits into from
May 21, 2021
Merged

Use marks #15

merged 7 commits into from
May 21, 2021

Conversation

abstractlyZach
Copy link
Owner

Goodbye IDs! You were unnecessarily complicated! Now we use user-defined marks

  • Use marks in toml
  • Use marks instead of titles to identify windows
  • upgrade pytest for verbose testing
  • Refactor layout to use marks instead of IDs

@codecov-commenter
Copy link

Codecov Report

Merging #15 (f5fe414) into main (0dd39af) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##              main       #15   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            5         5           
  Lines           72        55   -17     
  Branches         8         2    -6     
=========================================
- Hits            72        55   -17     
Impacted Files Coverage Δ
src/magic_tiler/layout.py 100.00% <100.00%> (ø)
src/magic_tiler/tiles.py 100.00% <100.00%> (ø)
src/magic_tiler/windows.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0dd39af...f5fe414. Read the comment docs.

@abstractlyZach abstractlyZach added the refactoring changes in design without changing functionality label May 21, 2021
@abstractlyZach abstractlyZach merged commit aa9926b into main May 21, 2021
@abstractlyZach abstractlyZach deleted the use-marks branch May 21, 2021 16:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactoring changes in design without changing functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants