Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rework loading the NOTICE from a NOTICE file #468

Closed
pombredanne opened this issue Jan 27, 2017 · 2 comments
Closed

Rework loading the NOTICE from a NOTICE file #468

pombredanne opened this issue Jan 27, 2017 · 2 comments
Labels
bug installation and packaging

Comments

@pombredanne
Copy link
Member

This was introduced in #424
But this https://github.com/nexB/scancode-toolkit/pull/424/files#diff-1e37ecfb9a8c3fccd8ecdfb2ce51f591R104 is making an assumption about the location of the NOTICE file which does not hold in a built wheel (the NOTICE is not package data setup-wise)
@pombredanne
Copy link
Member Author

@sschuberth commented 2 hours ago

Sorry for that. I wasn't even aware that ScanCode might be built as a wheel.

Do not worry, this is a tricky part in wheels and rather easy to get past it. A file that not inside a package is not readily accessible in a wheel (even though you can get to it in development). This is also an area that is and has been the subject of a lot of discussions. See:

Now, I started pushing a wheel a while ago but only on Github releases for now: https://github.com/nexB/scancode-toolkit/releases ... The goal is to to make this a Pypi wheel with 2.0.

This was not caught only because there is not a test for this!

@pombredanne pombredanne mentioned this issue Jan 28, 2017
Closed
pombredanne added a commit that referenced this issue Feb 17, 2017
@pombredanne
#381 Move scan formatters to a new "formattedcode" module
68d0a8a 
 * this is a first step towards #381
 * code and tests have been split from the scancode module
 * Also restore the ability to run ScanCode as a library by vendoring
   the NOTICE file. This was a regression introduced in #424 and
   tracked as #468
   

Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>
@pombredanne pombredanne mentioned this issue Feb 17, 2017
Merged
@pombredanne
Copy link
Member Author

This is working again now and is fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug installation and packaging
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@pombredanne