Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using build to build the sdist and wheel files #200

Merged
merged 4 commits into from
Dec 19, 2023

Conversation

Usman2ABN
Copy link
Collaborator

No description provided.

@Usman2ABN Usman2ABN linked an issue Nov 28, 2023 that may be closed by this pull request
@mbyrnepr2
Copy link
Contributor

Changes look perfect.
The CI failures are as expected but need fixing. The root-cause as described in #196.
The setup.py which references the requirements.txt is breaking the sdist. One solution could be to include requirements.txt in a MANIFEST.in but I would consider the approach taken in the wizard (refactored out the requirements.txt entirely).

@mbyrnepr2
Copy link
Contributor

This should also fix/close #181 btw.

@mbyrnepr2
Copy link
Contributor

mbyrnepr2 commented Nov 28, 2023

The latest CI failures seem to stem from the setup.cfg of the backend - Celery and its transitory dependencies install fine but every top-level dep after celery here is not installed. Looks like the indentation is off.

Other than that - I think we shouldn't pin these dependencies so tightly like this, because then we run into what is discussed in #181. But we can open a separate issue to tackle that if you prefer (I envisage it to end up like the setup.cfg/setup.py of the wizard where a range of versions are acceptable and not one specific version for each dependency - with the latter making it more likely that other packages in the same environment as resc will have conflicting package versions (since they have their own dependency requirements).

@mbyrnepr2
Copy link
Contributor

FYI added #201 so we can separate the version-pinning refactor into a different PR.

This should also fix/close #181 btw.

Peter-v-d-Spek
Peter-v-d-Spek previously approved these changes Dec 19, 2023
@Usman2ABN Usman2ABN merged commit d9b72fe into main Dec 19, 2023
@Usman2ABN Usman2ABN deleted the 196-fix-sdists-before-publishing branch December 19, 2023 12:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix sdists before publishing
3 participants