Use build to build the sdist and wheel files.
#195
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- `build` was previously installed but unused in the CI. - Running `python -m build` first creates a `sdist` and then creates a wheel from that sdist, ensuring the sdist works. - Remove install of `wheel` since we are using `build`.
Usman2ABN
approved these changes
Nov 23, 2023
Usman2ABN
approved these changes
Nov 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
build is currently installed but unused in the CI.
Running
python -m buildfirst creates asdistand then creates a wheel from that sdist, ensuring the sdist works.The current command gives no guarantee that the sdist would be usable when doing a
pip install sdist- This is the case with the other backend packages in the codebase currently; for example, try downloading the published resc-backend source distribution and doing apip install <sdist>.Remove install of
wheelsince we are usingbuild.