Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for ignore rules #184

Merged
merged 4 commits into from
Oct 12, 2023
Merged

Add support for ignore rules #184

merged 4 commits into from
Oct 12, 2023

Conversation

ildyria
Copy link
Contributor

@ildyria ildyria commented Oct 12, 2023

Ignoring findings

It is possible to ignore some blocker findings (e.g. false positive) by providing
a resc-ignore.dsv file. The bockers will be downgraded to a warning level and marked as ignored. Such file has the following structure:

# This is a comment
finding_path|finding_rule|finding_line_number|expiration_date
finding_path_2|finding_rule_2|finding_line_number_2
  • finding_path contains the path to the file with the blocking finding.
  • finding_rule contains the name of the blocking rule.
  • finding_line_number contains the line number of the finding.
  • expiration_date is optional, contains the date in ISO 8601 format until which this ignore rule should be considered valid.

For example, if we want to ignore the finding in file /etc/passwd for rule root_value_found on line 1 until April 1st 2024 at 23:59 the following line should be used.

/etc/passwd|root_value_found|1|2024-04-01T23:59:00

To ignore this finding ad vitam aeternam:

/etc/passwd|root_value_found|1

@BVabn BVabn requested review from Peter-v-d-Spek, Usman2ABN and amrityamrout and removed request for Usman2ABN October 12, 2023 09:19
@BVabn BVabn merged commit 12507ae into abnamro:main Oct 12, 2023
@ildyria ildyria deleted the 2775181 branch October 24, 2023 13:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants