Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update tox.ini and fix install requirements #181

Closed
wants to merge 2 commits into from
Closed

Update tox.ini and fix install requirements #181

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9bc6114
avoid installing tox directly but install test-requirements instead
ildyria Oct 5, 2023
55e77d5
missed tox config
ildyria Oct 5, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 5 additions & 4 deletions components/resc-backend/tox.ini
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,10 +3,11 @@
skipsdist = true
skip_install = true
passenv = PIP_CONFIG_FILE
commands = pip install -r test-requirements.txt
pip install -e .
commands = pip install -e .
flake8 src/ tests/
pylint src/
allowlist_externals = flake8
pylint

[testenv:sort]
skipsdist = true
Expand All @@ -20,11 +21,11 @@ commands = pip install isort==5.5.1
skipsdist = true
skip_install = true
passenv = PIP_CONFIG_FILE
commands = pip install -r test-requirements.txt
pip install -e .
commands = pip install -e .
coverage run -m pytest
coverage report -m
coverage xml --data-file=.coverage
allowlist_externals = coverage

[coverage:run]
relative_files = True
Expand Down
2 changes: 1 addition & 1 deletion components/resc-vcs-scanner/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -200,7 +200,7 @@ Run below commands to make sure that the unit tests are running and that the cod

_**Note:**_ To run these tests you need to install [tox](https://pypi.org/project/tox/). This can be done on Linux and Windows with Git Bash.
```bash
pip install tox # install tox locally
pip install -r test-requirements.txt # install tox locally

tox -v -e sort # Run this command to validate the import sorting
tox -v -e lint # Run this command to lint the code according to this repository's standard
Expand Down
9 changes: 5 additions & 4 deletions components/resc-vcs-scanner/tox.ini
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,11 +3,12 @@
skipsdist = true
skip_install = true
passenv = PIP_CONFIG_FILE
commands = pip install -r test-requirements.txt
pip install -e ../resc-backend
commands = pip install -e ../resc-backend
pip install -e .
flake8 src/ tests/
pylint src/
allowlist_externals = flake8
pylint

[testenv:sort]
skipsdist = true
Expand All @@ -21,12 +22,12 @@ commands = pip install isort==5.5.1
skipsdist = true
skip_install = true
passenv = PIP_CONFIG_FILE
commands = pip install -r test-requirements.txt
pip install -e ../resc-backend
commands = pip install -e ../resc-backend
pip install -e .
coverage run -m pytest
coverage report -m
coverage xml --data-file=.coverage
allowlist_externals = coverage

[coverage:run]
relative_files = True
Expand Down
9 changes: 5 additions & 4 deletions components/resc-vcs-scraper/tox.ini
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,10 +4,11 @@ skipsdist = true
skip_install = true
passenv = PIP_CONFIG_FILE
setenv = PYTHONPATH = {toxinidir}:{toxinidir}/src
commands = pip install -r test-requirements.txt --quiet
pip install -e .
commands = pip install -e .
flake8 src/ tests/
pylint src/
allowlist_externals = flake8
pylint

[testenv:sort]
skipsdist = true
Expand All @@ -22,11 +23,11 @@ skipsdist = true
skip_install = true
setenv = PYTHONPATH = {toxinidir}:{toxinidir}/src
passenv = PIP_CONFIG_FILE
commands = pip install -r test-requirements.txt --quiet
pip install -e .
commands = pip install -e .
coverage run -m pytest
coverage report -m
coverage xml --data-file=.coverage
allowlist_externals = coverage

[coverage:run]
relative_files = True
Expand Down
2 changes: 2 additions & 0 deletions deployment/resc-helm-wizard/tox.ini
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,12 +16,14 @@ skipsdist = true
skip_install = true
commands =
flake8 src/
allowlist_externals = flake8

[testenv:pylint]
description = Run `pylint src/`
skipsdist = true
commands =
pylint src/
allowlist_externals = pylint

[testenv:isort]
description = Run `isort src/ tests/`
Expand Down