Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#2578799] Skip scanning empty repositories #154

Merged
merged 1 commit into from
Aug 11, 2023
Merged

[#2578799] Skip scanning empty repositories #154

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion components/resc-vcs-scanner/src/vcs_scanner/secret_scanners/cli.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -260,7 +260,8 @@ def scan_repository(args: Namespace):
username=args.username,
personal_access_token=args.password,
local_path=f"{args.dir.absolute()}",
force_base_scan=args.force_base_scan
force_base_scan=args.force_base_scan,
latest_commit="unknown"
)

secret_scanner.run_repository_scan()
Expand Down
5 changes: 5 additions & 0 deletions components/resc-vcs-scanner/src/vcs_scanner/secret_scanners/secret_scanner.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,6 +66,11 @@ def clone_repo(self) -> str:
return repo_clone_path

def run_repository_scan(self) -> None:
if not self.latest_commit:
# There is no latest commit for this repository, assuming that its empty
logger.info(f"Skipping scanning of {self.repository.project_key}/{self.repository.repository_name} "
f"there are no commits")
return
logger.info(
f"Started task for scanning {self.repository.repository_name} using "
f"rule pack version: {self.rule_pack_version}")
Expand Down
9 changes: 7 additions & 2 deletions components/resc-vcs-scraper/src/vcs_scraper/repository_collector/common.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,9 +42,14 @@ def extract_project_information(project_key, vcs_client, vcs_instance_name):
logger.info(f"Fetching latest commit for repository: '{project_key}/{repository['name']}'")
latest_commit = vcs_client.get_latest_commit(project_key=project_key, repository_id=repository["name"])
task_parameters = vcs_client.export_repository(repository, latest_commit, vcs_instance_name)
project_tasks.append(task_parameters)
if latest_commit:
project_tasks.append(task_parameters)
logger.info(f"Information for repository: '{project_key}/{repository['name']}' "
f"was fetched successfully")
else:
# Repository has no commits, will not forward to scanner
logger.info(f"Repository: '{project_key}/{repository['name']}' has no commits, skipping")

logger.info(f"Information for repository: '{project_key}/{repository['name']}' was fetched successfully")
except requests.exceptions.HTTPError as http_exception:
logger.error(
f"Error while processing repository '{project_key}/{repository['name']}':"
Expand Down