Kueue job priorities #13
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jobs can now specify `SchedulingOptions`, which include the Kueue local queue and priority class names. Adds example priority classes (background, development, production) and preemption options to the cluster queue manifest. A sample "production" job has been added to simplify the demo of preemption and priority based workload ordering in Kueue.
nicholasjng
reviewed
Apr 18, 2024
The `runner.py` module was growing to a point where readability was hampered. This commit splits it up into the `jobs.runner` package, with submodules grouped by execution platform. Also, introduces a `KubernetesNamespaceMixin` to simplify determining the current or desired namespace for a workload.
Closed
1 task
nicholasjng
reviewed
Apr 23, 2024
maxmynter
reviewed
Apr 23, 2024
Comment on lines
-144
to
+160
| resources: ResourceOptions | None | ||
| resources: ResourceOptions | None = None | ||
| """Resource requests for this job in Kubernetes format (see https://kubernetes.io/docs/concepts/configuration/manage-resources-containers/#resource-units-in-kubernetes)""" | ||
| image: ImageOptions | None | ||
| image: ImageOptions | None = None | ||
| scheduling: SchedulingOptions | None = None |
There was a problem hiding this comment.
How do we handle if these are not set?
There was a problem hiding this comment.
Up to the implementation of the runners to decide. Some might throw an error, whereas others might completely ignore an option that was passed because it is not applicable (e.g., resource limits when executing locally).
Comment on lines
+1
to
+3
| import logging | ||
|
|
||
| from kubernetes import client |
There was a problem hiding this comment.
Should we name the runner directory runners since it contains multiple runners?
There was a problem hiding this comment.
I kept it as runner so imports of the types would remain stable, but I'm open to renaming it as well.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Scheduling Options (priority classes / Kueue local queue)
Jobs can now specify
SchedulingOptions, which include the Kueue local queue and priority class names. The settings are validated upon job submission.Adds example priority classes (background, development, production) and preemption options to the Kueue cluster queue manifest YAML.
A sample "production" job has been added to simplify the demo of preemption and priority based workload ordering in Kueue.
Refactorings
The
runner.pymodule was broken up into a proper packagejobs.runner, since its size was growing to a point where readability was hampered.Breaking Changes
If you have previously set up Kueue in your cluster with the
single-clusterqueue-setup.yamlmanifest, you will have to reapply these resources.Closes #9, #10