-
Notifications
You must be signed in to change notification settings - Fork 121
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
change(consensus): Updates transaction verifier to use orchard::bundle::BatchValidator
#9308
Draft
arya2
wants to merge
4
commits into
main
Choose a base branch
from
extend-tower-batch-control
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…mpls `ItemSIze` for them.
…size()` instead of 1, and increases halo2 max batch size from 2 to 64
arya2
commented
Feb 28, 2025
Ok(()) | ||
} | ||
} | ||
let bundle = orchard::bundle::Bundle::from_parts( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR should use the orchard bundle created when preparing to compute transaction sighashes instead of converting orchard data to the orchard
crate Bundle
type twice.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
We want Zebra to validate orchard proofs in batches as it does for other pools.
This PR also makes some progress towards deduplicating logic in zebra-chain that's available in the
orchard
crate.Closes #4672
Solution
ItemSize
trait intower-batch-control
defining anitem_size()
method,ItemSize
for them where all of them return 1 (no change in behaviour) except for the halo2 verifier which returns the number of actions in the request,pending_items
in the batch control worker byitem_size()
instead of 1,HALO2_MAX_BATCH_SIZE
from 2 to 64Tests
This PR still needs tests. It also removes some tests that are no longer relevant.
Follow-up Work
Use
shardtree
to append to note commitment trees in parallelPR Checklist
C-exclude-from-changelog
label.