check number of commitments in sign() #480
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #480 +/- ##
==========================================
+ Coverage 77.48% 77.82% +0.33%
==========================================
Files 30 30
Lines 2754 2787 +33
==========================================
+ Hits 2134 2169 +35
+ Misses 620 618 -2
☔ View full report in Codecov by Sentry. |
conradoplg
force-pushed
the
check-number-commitments
branch
from
059cde4 to
418fa4d
Compare
26 tasks
|
Solved conflicts |
natalieesk
reviewed
Sep 4, 2023
natalieesk
requested changes
Sep 4, 2023
natalieesk
approved these changes
Sep 5, 2023
natalieesk
previously approved these changes
Sep 5, 2023
conradoplg
force-pushed
the
check-number-commitments
branch
from
856557a to
fa7f652
Compare
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #455
Not fully sure if it's worth checking this (it's not required, the signature generation would fail anyway), but it works as a second layer of validation and it seems useful for users to be able to know what is the min_signers value by getting it from the KeyPackage. Let me know what you think.
This also adds a test for trying to sign with less than min_signers share (even bypassing this new min_signers value check) which is useful in itself and makes sure we're not interpreting thresholds wrong.