Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[NCC-E008263-XLV] frost-core: Minimum Participant Constraint Enforcement Improvements #443

Closed
Tracked by #451
conradoplg opened this issue Jul 19, 2023 · 0 comments · Fixed by #453
Closed
Tracked by #451

[NCC-E008263-XLV] frost-core: Minimum Participant Constraint Enforcement Improvements #443

conradoplg opened this issue Jul 19, 2023 · 0 comments · Fixed by #453
Assignees
@natalieesk
Milestone
FROST Audit

Comments

@conradoplg
Copy link
Contributor

generate_secret_polynomial contains common input validation for min/max_signers, but these validations happen too late. In particular, split() can panic since it passes min_signers -1.

  • Refactor the validations into a separate function if possible, and call it where appropriate.
  • Fix the panic in split()

One idea is to create a type e.g. "ValidConfig" which can only be constructed with a valid configuration and use that everywhere that is needed.
@mpguerra mpguerra mentioned this issue Jul 24, 2023
Closed
26 tasks
@mpguerra mpguerra changed the title Minimum Participant Constraint Enforcement Improvements [NCC-E008263-XLV] frost-core: Minimum Participant Constraint Enforcement Improvements Jul 24, 2023
@natalieesk natalieesk self-assigned this Jul 25, 2023
natalieesk added a commit that referenced this issue Jul 26, 2023
@natalieesk
Add validation for participant numbers (#443)
6eaf888 
Add to split() and generate_secret_polynomial()
@natalieesk natalieesk mentioned this issue Jul 26, 2023
Merged
natalieesk added a commit that referenced this issue Aug 16, 2023
@natalieesk
Add participant validation for dkg and repairable (#443)
9f67c3d
@mergify mergify bot closed this as completed in #453 Aug 16, 2023
mergify bot pushed a commit that referenced this issue Aug 16, 2023
@natalieesk
Add minimum participant constraints (#453)
bb94a34 
* Add validation for missing identifier in signing package (#442)

* Add error handling for identifier having an invalid commitment (#442)

* Fixed comment (#442)

* Add validation for participant numbers (#443)

Add to split() and generate_secret_polynomial()

* Add participant validation for dkg and repairable (#443)
@mpguerra mpguerra added this to the FROST Audit milestone Aug 24, 2023
@mpguerra mpguerra added this to FROST Aug 24, 2023
@mpguerra mpguerra moved this to Done in FROST Aug 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@natalieesk natalieesk

Labels
None yet
Projects
FROST
Archived in project
Milestone
FROST Audit
Development

Successfully merging a pull request may close this issue.

Add minimum participant constraints ZcashFoundation/frost
3 participants
@conradoplg @mpguerra @natalieesk