Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix config is_public #84

Merged
merged 1 commit into from
Jan 27, 2020
Merged

fix config is_public #84

merged 1 commit into from
Jan 27, 2020

Conversation

kay0u
Copy link
Member

@kay0u kay0u commented Jan 15, 2020 •
edited by maniackcrudelis
Loading

Problem

  • Change is_public was not working as expected

Solution

  • is_public is either 1 or 0 (not true of false)

PR Status

  • Code finished.
  • Tested with Package_check.
  • Fix or enhancement tested.
  • Upgrade from last version tested.
  • Can be reviewed and tested.

Validation

Minor decision

  • Upgrade previous version :
  • Code review : Maniack C
  • Approval (LGTM) : Maniack C
  • Approval (LGTM) :
  • CI succeeded :
    Build Status
    When the PR is marked as ready to merge, you have to wait for 3 days before really merging it.

@kay0u kay0u requested a review from a team January 15, 2020 17:22
@maniackcrudelis maniackcrudelis requested a review from a team January 19, 2020 11:23
JimboJoe
JimboJoe approved these changes Jan 19, 2020
View reviewed changes
Copy link

@JimboJoe JimboJoe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@JimboJoe
Copy link

Can be merged in 3 days.

@maniackcrudelis maniackcrudelis merged commit c56f303 into testing Jan 27, 2020
@maniackcrudelis maniackcrudelis deleted the fix-config branch January 27, 2020 22:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JimboJoe JimboJoe JimboJoe approved these changes

@maniackcrudelis maniackcrudelis maniackcrudelis approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kay0u @JimboJoe @maniackcrudelis