fix: trigger api support multi listeners jaywcjlove#403

Yukiniro · Nov 23, 2022 · f0dc168 · f0dc168
1 parent 9d45f35
commit f0dc168
Show file tree

Hide file tree

Showing 2 changed files with 28 additions and 4 deletions.
diff --git a/src/index.js b/src/index.js
@@ -397,10 +397,12 @@ function hotkeys(key, option, method) {
 
 function trigger(shortcut, scope = 'all') {
   Object.keys(_handlers).forEach((key) => {
-    const data = _handlers[key].find((item) => item.scope === scope && item.shortcut === shortcut);
-    if (data && data.method) {
-      data.method();
-    }
+    const dataList = _handlers[key].filter((item) => item.scope === scope && item.shortcut === shortcut);
+    dataList.forEach((data) => {
+      if (data && data.method) {
+        data.method();
+      }
+    });
   });
 }
 

diff --git a/test/run.test.js b/test/run.test.js
@@ -694,6 +694,28 @@ describe('\n   Hotkeys.js Test Case222.\n', () => {
     await hotkeys.unbind('a');
   });
 
+  test('Hotkey trigger whith shortcut.', async () => {
+    let count = 0;
+    hotkeys('a', () => {
+      count++;
+    });
+    hotkeys.trigger('a');
+    expect(count).toBe(1);
+    hotkeys.unbind('a');
+  });
+
+  test('Hotkey trigger whith multi shortcut.', async () => {
+    let count = 0;
+    for (let i = 0; i < 3; i++) {
+      hotkeys('a', () => {
+        count++;
+      });
+    }
+    hotkeys.trigger('a');
+    expect(count).toBe(3);
+    hotkeys.unbind('a');
+  });
+
   afterAll(async () => {
     await browser.close();
   });