Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Travis: remove nightly #299

Merged
merged 1 commit into from
Sep 28, 2021
Merged

Travis: remove nightly #299

merged 1 commit into from
Sep 28, 2021

Conversation

jrfnl
Copy link
Contributor

@jrfnl jrfnl commented Sep 28, 2021

Summary

This PR can be summarized in the following changelog entry:

  • Updates CI

Relevant technical choices:

At this time, the current PHP 8.0 version is 8.0.11. The Travis PHP 8.0 image yields PHP 8.0.9, which is good enough for PHP 8.0.

nightly however is PHP 8.0.3 and hasn't been updated since Feb 2021, so running tests against that image is completely useless at this time.

Notes:
* Tested nightly against all relevant dists - xenial, bionic and focal and none have a more current image.
* The PHP Build project, which Travis pulls its images from, does have a PHP 8.1snapshot image available.
I've tested to see if that image is available on Travis, but unfortunately, no luck there either.

Test instructions

This PR can be tested by following these steps:

  • N/A If the build passes, we're good.

At this time, the current PHP 8.0 version is `8.0.11`. The Travis PHP `8.0` image yields PHP `8.0.9`, which is good enough for PHP 8.0.

`nightly` however is PHP `8.0.3` and hasn't been updated since Feb 2021, so running tests against that image is completely useless at this time.

Notes:
    * Tested `nightly` against all relevant `dist`s - `xenial`, `bionic` and `focal` and none have a more current image.
    * The [PHP Build project](https://github.com/php-build/php-build/tree/master/share/php-build/definitions), which Travis pulls its images from, _does_ have a PHP `8.1snapshot` image available.
        I've tested to see if that image is available on Travis, but unfortunately, no luck there either.
@jrfnl jrfnl added yoast cs/qa changelog: non-user-facing Needs to be included in the 'Non-userfacing' category in the changelog labels Sep 28, 2021
@jrfnl jrfnl added this to the 3.x / Next Release milestone Sep 28, 2021
@jrfnl jrfnl merged commit 48b01c7 into develop Sep 28, 2021
@jrfnl jrfnl deleted the JRF/QA/travis-remove-nightly branch September 28, 2021 15:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog: non-user-facing Needs to be included in the 'Non-userfacing' category in the changelog yoast cs/qa
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant