Skip to content
This repository has been archived by the owner on Feb 28, 2025. It is now read-only.

Simplify JSX a11y rules to use the recommended ones #13

Merged
merged 7 commits into from
Sep 24, 2018
Merged

Conversation

afercia
Copy link
Contributor

@afercia afercia commented Sep 21, 2018

  • uses the jsx-a11y/recommended rules
  • with one exception for label-has-for, which is deprecated in v6.1.0 in favor of label-has-associated-control but we still want to require only for/id and not nesting
  • sets react/button-has-type to warning as this rule is pretty useless in its current state
  • adds an exception for translators comments in capitalized-comments

Fixes #12

@afercia afercia requested a review from atimmer September 21, 2018 09:46
@afercia
Copy link
Contributor Author

afercia commented Sep 21, 2018

Note: in a first moment I thought lowering to warnings a few rules was a good idea. Reverted that, as we're going to add exceptions where needed in the various projects. See also this previous change 596245d

@afercia
Copy link
Contributor Author

afercia commented Sep 21, 2018

I've pushed two branches for the plugin, to test the new ESLint rules. This PR changes are not released yet so to test there's the need to yarn-link the local copy of this branch.

free: eslint-jsx-a11y-new-config
premium: eslint-config-premium

@afercia
Copy link
Contributor Author

afercia commented Sep 24, 2018

Test branch for yoast-components: eslint-new-rules-adjustments
(0 errors, 356 warnings 😄)

@atimmer atimmer merged commit 5ee7e29 into master Sep 24, 2018
@afercia
Copy link
Contributor Author

afercia commented Sep 24, 2018

Test branch for YoastSEO.js: eslint-jsx-a11y-config

@diedexx diedexx deleted the update-jsx-a11y branch March 11, 2019 13:30
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants