Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Building Projects: Add support for calling batch files during a Clean operation #8695

Closed
KeeVeeGames opened this issue Dec 13, 2024 · 4 comments
Closed

Building Projects: Add support for calling batch files during a Clean operation #8695

KeeVeeGames opened this issue Dec 13, 2024 · 4 comments
Assignees
@rwkay @sihammill @YYBartT
Labels
documentation Improvements or additions to documentation are required by this issue feature request New feature (or a request for one)
Milestone
2024.13

Comments

@KeeVeeGames
Copy link

KeeVeeGames commented Dec 13, 2024 •
edited
Loading

Is your feature request related to a problem?

I am developing a shader preprocessor (https://github.com/KeeVeeGames/Shady.gml) and have already hooked it up to the compilation process with batch scripts, but the occasional "--clean" option still requires manual execution

Describe the solution you'd like

I would like to have a new batch / sh script that will run when the user presses the Clean option in IDE.

Describe alternatives you've considered

No response

Additional context

No response
@KeeVeeGames KeeVeeGames added the feature request New feature (or a request for one) label Dec 13, 2024
@stuckie stuckie moved this from Triage to Todo in Team Workload Dec 16, 2024
@stuckie stuckie added this to the 2024.13 milestone Dec 16, 2024
@rwkay
Copy link

rwkay commented Jan 6, 2025

Added in 2024.13 - new batch and shell scripts can be added for pre_clean_step.bat (or pre_clean_step.sh) AND post_clean_step.bat (or post_clean_step.sh) - these can also be added to extensions as usual

@rwkay rwkay closed this as completed Jan 6, 2025
@github-project-automation github-project-automation bot moved this from Todo to Done in Team Workload Jan 6, 2025
@KeeVeeGames
Copy link
Author

Thanks!

@gurpreetsinghmatharoo gurpreetsinghmatharoo added the documentation Improvements or additions to documentation are required by this issue label Jan 7, 2025
@YYDan YYDan changed the title Add support for for Clean batch script. Building Projects: Add support for calling batch files on a Clean operation Jan 7, 2025
@YYDan YYDan changed the title Building Projects: Add support for calling batch files on a Clean operation Building Projects: Add support for calling batch files during a Clean operation Jan 7, 2025
@KeeVeeGames KeeVeeGames mentioned this issue Jan 7, 2025
Closed
@YYBartT YYBartT self-assigned this Jan 13, 2025
@sihammill
Copy link

Feature verified in Beta IDE v2024.1300.0.721 Runtime v2024.1300.0.734

YYBartT added a commit to YoYoGames/GameMaker-Manual that referenced this issue Jan 17, 2025
@YYBartT
docs(feature): Building Projects: Add support for calling batch files…
7a72549 
… during a Clean operation

YoYoGames/GameMaker-Bugs#8695

Compiler Batch Files page: Added a new table underneath the existing one in the "Execution" section
YYBartT added a commit to YoYoGames/GameMaker-Manual that referenced this issue Jan 17, 2025
@YYBartT
docs(feature): Building Projects: Add support for calling batch files…
f8591a4 
… during a Clean operation

YoYoGames/GameMaker-Bugs#8695

Compiler Batch Files page: Small change to the note to make it clearer that it applies to both tables
@YYBartT
Copy link

YYBartT commented Jan 17, 2025

Added a second table to the Compiler Batch Files / Scripts manual page under "Execution" that lists the scripts that are executed (in the order listed) during a clean of the cache.

@YYBartT YYBartT moved this from Done to Ready for QA in Team Workload Jan 17, 2025
@sihammill sihammill moved this from Ready for QA to Verified in Team Workload Jan 20, 2025
@YYBartT YYBartT mentioned this issue Jan 21, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rwkay rwkay

@sihammill sihammill

@YYBartT YYBartT

Labels
documentation Improvements or additions to documentation are required by this issue feature request New feature (or a request for one)
Projects
Team Workload
Status: Verified
Milestone
2024.13
Development

No branches or pull requests
6 participants
@stuckie @rwkay @KeeVeeGames @gurpreetsinghmatharoo @sihammill @YYBartT