Added status support for gmio and ext buffers #8903
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bisingha-xilinx
requested review from
larry9523,
stsoe,
rozumx and
uday610
as code owners
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
stsoe
requested changes
Apr 23, 2025
Signed-off-by: bisingha <bikash.singha@amd.com>
Signed-off-by: bisingha <bikash.singha@amd.com>
Signed-off-by: bisingha <bikash.singha@amd.com>
Signed-off-by: bisingha <bikash.singha@amd.com>
bisingha-xilinx
force-pushed
the
gmio-extbuf-status
branch
from
30edb0b to
c3daba1
Compare
|
clang-tidy review says "All clean, LGTM! 👍" |
stsoe
requested changes
Apr 28, 2025
Signed-off-by: bisingha <bikash.singha@amd.com>
|
clang-tidy review says "All clean, LGTM! 👍" |
stsoe
approved these changes
Apr 28, 2025
chvamshi-xilinx
approved these changes
Apr 28, 2025
bisingha-xilinx
added a commit
to bisingha-xilinx/XRT
that referenced
this pull request
Apr 28, 2025
* Added status support for gmio and ext buffers Signed-off-by: bisingha <bikash.singha@amd.com> * Added check to avoid getting status before async Signed-off-by: bisingha <bikash.singha@amd.com> * Added headers and renamed the status() func of xrt::aie::buffer Signed-off-by: bisingha <bikash.singha@amd.com> * Added enum class state for aie buffer object Signed-off-by: bisingha <bikash.singha@amd.com> * Moved buffer_state to device class Signed-off-by: bisingha <bikash.singha@amd.com> --------- Signed-off-by: bisingha <bikash.singha@amd.com> (cherry picked from commit 7c3edf3)
chvamshi-xilinx
pushed a commit
that referenced
this pull request
Apr 28, 2025
* Added status support for gmio and ext buffers * Added check to avoid getting status before async * Added headers and renamed the status() func of xrt::aie::buffer * Added enum class state for aie buffer object * Moved buffer_state to device class --------- (cherry picked from commit 7c3edf3) Signed-off-by: bisingha <bikash.singha@amd.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem solved by the commit
https://jira.xilinx.com/browse/CR-1210116.
Bug / issue (if any) fixed, which PR introduced the bug, how it was discovered
Not a bug. It's a new feature for GMIO and external buffer usecases. It is a new member function of xrt::aie::buffer class which will get the status of the previously initiated async operation.
How problem was solved, alternative solutions (if any) and why they were rejected
By adding a new member function to xrt::aie::buffer class
Risks (if any) associated the changes in the commit
What has been tested and how, request additional testing if necessary
Tested on vck190 and vek280 with GMIO and external buffer testcases
Documentation impact (if any)
status() of xrt::aie::buffer needs to be documented