Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#576: Add support for AMMClawback #601

Open
wants to merge 25 commits into
base: main
Choose a base branch
from
Open

#576: Add support for AMMClawback #601

wants to merge 25 commits into from

Conversation

agutierrez0
Copy link
Contributor

@agutierrez0 agutierrez0 commented Feb 19, 2025 •
edited
Loading

closes #576

  • add AmmClawback to SignatureUtils, Transaction.java, TransactionType.java, and TransactionTypeTests.java
    • add test in SignatureUtils for the new AmmClawback class
  • create AmmClawbackFlags with only tfCalwTwoAssets flag or unset flags
  • create AmmClawback under transactions
  • generate new definitions.json
  • create new AmmClawbackTest transaction test
  • updated rippled container version to 2.3.0 from 2.2.0-rc3
  • enable new AMMClawback amendment in rippled.cfg
  • added integration tests under AmmIt
    • one test where we clawback with amount
    • one test where we clawback two assets using tfClawbackTwoAssets
    • one test where we clawback without amount and only clawback one asset

sappenin
sappenin requested changes Feb 26, 2025
View reviewed changes
@nkramer44 nkramer44 self-assigned this Mar 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nhartner nhartner Awaiting requested review from nhartner nhartner is a code owner

@nkramer44 nkramer44 Awaiting requested review from nkramer44 nkramer44 is a code owner

@sappenin sappenin Awaiting requested review from sappenin sappenin is a code owner

Requested changes must be addressed to merge this pull request.

Assignees

@nkramer44 nkramer44

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add support for AMM Clawback (XLS-74d)
3 participants
@agutierrez0 @sappenin @nkramer44