-
Notifications
You must be signed in to change notification settings - Fork 531
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: update snippets to be compatible with xrpl.js #1706
Conversation
da6150e
to
07f117b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks like there's some git issues with a different branch, so I'll hold off on approval until that's resolved
Looks like you have some old merge commits. you should |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Snippets look great.
Once the merge issues are resolved, feel free to merge the snippets.
You could also
git checkout develop
# switch to tmp branch
git checkout -b tmp
# Bring your changes in ./snippets to temp branch
git checkout update-snippets -- ./snippets
# back to this branch
git checkout update-snippets
# make this branch your tmp branch, with only the changes from ./snippets
git reset --hard tmp
# push
git push --force
Just make a backup branch in case you mess something up lol
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
see comments
cf579a8
to
50dba6e
Compare
* removes getFeeXrp from client
* update phrasing * account -> address
* README: quick cleanup Co-authored-by: Mayukha Vadari <mvadari@ripple.com>
* build: update @xrplf/typescript-style * fix filename casing * fix webpack setup * add missing eslint plugin Co-authored-by: Nathan Nichols <natenichols@cox.net>
* refactor: waits on closing test to end tests
Looks like there were similar changes with |
oh I see what the issue is - if you're working on top of someone else's branch, you can only use the version of |
High Level Overview of Change
Update snippets to be compatible with xrpl.js
Context of Change
Updated
getTransaction
&paths
snippets to be compatible with xrpl.js.Type of Change
Test Plan
Manually tested snippets to ensure they are functional.