Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove: Hooks faucet #705

Merged
merged 10 commits into from
May 15, 2024
Merged

remove: Hooks faucet #705

merged 10 commits into from
May 15, 2024

Conversation

khancode
Copy link
Collaborator

@khancode khancode commented May 15, 2024 •
edited
Loading

High Level Overview of Change

Remove Hooks faucet since it's now on the Xahau testnet. This also removes its flaky integ test.

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Refactor (non-breaking change that only restructures code)
  • Tests (You added tests for code that already exists, or your new feature included in this PR)
  • Documentation Updates
  • Release

Did you update CHANGELOG.md?

  • Yes
  • No, this change does not impact library users

Test Plan

Remove flaky integ test.

@khancode khancode changed the title fix: remove Hooks faucet remove: Hooks faucet May 15, 2024
@mvadari mvadari self-requested a review May 15, 2024 21:16
mvadari
mvadari requested changes May 15, 2024
View reviewed changes
Copy link
Collaborator

@mvadari mvadari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adding the block just because I want the network ID test back.

@khancode khancode requested a review from mvadari May 15, 2024 21:35
@khancode khancode merged commit ae2ac9c into main May 15, 2024
21 checks passed
@khancode khancode deleted the remove-hooks-faucet branch May 15, 2024 22:14
@pdp2121 pdp2121 mentioned this pull request Aug 23, 2024
Closed
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@justinr1234 justinr1234 justinr1234 approved these changes

@mvadari mvadari mvadari approved these changes

@pdp2121 pdp2121 Awaiting requested review from pdp2121

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@khancode @justinr1234 @mvadari