refactor: make transaction flag mapping more maintainable #677
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mvadari
commented
Jan 31, 2024
| tf_sell_token=True, | ||
| TF_SELL_NFTOKEN=True, |
There was a problem hiding this comment.
Noting this as originally having the wrong name
khancode
reviewed
Feb 1, 2024
Co-authored-by: Omar Khan <khancodegt@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
High Level Overview of Change
This PR makes transaction flag mapping more maintainable and fixes the tests so they actually run properly. The
XChainModifyBridgevalidations were also fixed, due to catching a bug while writing tests for this PR.This process also caught a bug with the
NFTokenCreateOfferflag names.Context of Change
When reviewing #663 I looked at how transaction flags were processed, which made me realize that the
XChainModifyBridgeflags were missed. Then I wanted to make it more maintainable, to avoid this problem in the future (I didn't know this was a place I needed to update).Type of Change
Did you update CHANGELOG.md?
Test Plan
Existing tests pass. Added a test for
XChainModifyBridgeflags.