fix: export get_nftoken_id and parse_nftoken_id, better error handling
#646
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ckniffen
reviewed
Sep 21, 2023
| @@ -97,6 +97,9 @@ def has_nftoken_page(node: Node) -> bool: | |||
|
|
|||
| affected_nodes = [node for node in meta["AffectedNodes"] if has_nftoken_page(node)] | |||
|
|
|||
| if len(affected_nodes) == 0: | |||
There was a problem hiding this comment.
Is it typical to throw a exception and not just return None. This would be a normal occurance in cases where there is a tec code.
There was a problem hiding this comment.
I think it'd be more difficult to identify a bug if it returns None instead of erroring.
There was a problem hiding this comment.
I agree with Mayukha's approach of throwing an error because it indicates invalid user input; this justifies throwing an error. We should probably make it consistent with JS to throw an error too.
There was a problem hiding this comment.
However, it's also valid to have a failed transaction and not throw an error. So now I'm leaning more towards not throwing an error and keeping things consistent 😄
khancode
approved these changes
Sep 26, 2023
ckniffen
approved these changes
Sep 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
High Level Overview of Change
This PR:
get_nftoken_idandparse_nftoken_idat thexrpl.utilslevelget_nftoken_idif a metadata for an unrelated transaction is accidentally passed inContext of Change
Noticed while working on #417
Type of Change
Did you update CHANGELOG.md?
Test Plan
Added a test.