addressed Omar's comments

XRPLF · Dec 20, 2024 · 387f72b · 387f72b
1 parent e168dcb
commit 387f72b
Show file tree

Hide file tree

Showing 4 changed files with 16 additions and 16 deletions.
diff --git a/xrpl/models/transactions/credential_accept.py b/xrpl/models/transactions/credential_accept.py
@@ -23,11 +23,6 @@ class CredentialAccept(Transaction):
     it has been transferred/accepted.
     """
 
-    transaction_type: TransactionType = field(
-        default=TransactionType.CREDENTIAL_ACCEPT,
-        init=False,
-    )
-
     account: str = REQUIRED  # type: ignore
     """
     The subject of the credential.
@@ -43,6 +38,11 @@ class CredentialAccept(Transaction):
     A hex-encoded value to identify the type of credential from the issuer.
     """
 
+    transaction_type: TransactionType = field(
+        default=TransactionType.CREDENTIAL_ACCEPT,
+        init=False,
+    )
+
     def _get_errors(self: Self) -> Dict[str, str]:
         errors = super()._get_errors()
         if (

diff --git a/xrpl/models/transactions/credential_create.py b/xrpl/models/transactions/credential_create.py
@@ -23,11 +23,6 @@
 class CredentialCreate(Transaction):
     """This transaction creates a Credential object. It must be sent by the issuer."""
 
-    transaction_type: TransactionType = field(
-        default=TransactionType.CREDENTIAL_CREATE,
-        init=False,
-    )
-
     account: str = REQUIRED  # type: ignore
     """
     The issuer of the credential.
@@ -54,6 +49,11 @@ class CredentialCreate(Transaction):
     Credential document).
     """
 
+    transaction_type: TransactionType = field(
+        default=TransactionType.CREDENTIAL_CREATE,
+        init=False,
+    )
+
     def _get_errors(self: Self) -> Dict[str, str]:
         errors = super()._get_errors()
 

diff --git a/xrpl/models/transactions/credential_delete.py b/xrpl/models/transactions/credential_delete.py
@@ -20,10 +20,6 @@
 class CredentialDelete(Transaction):
     """This transaction deletes a Credential object."""
 
-    transaction_type: TransactionType = field(
-        default=TransactionType.CREDENTIAL_DELETE, init=False
-    )
-
     account: str = REQUIRED  # type: ignore
     """The transaction submitter."""
 
@@ -37,6 +33,10 @@ class CredentialDelete(Transaction):
     credential_type: str = REQUIRED  # type: ignore
     """A hex-encoded value to identify the type of credential from the issuer."""
 
+    transaction_type: TransactionType = field(
+        default=TransactionType.CREDENTIAL_DELETE, init=False
+    )
+
     def _get_errors(self: Self) -> Dict[str, str]:
         errors = super()._get_errors()
 

diff --git a/xrpl/models/utils.py b/xrpl/models/utils.py
@@ -10,12 +10,12 @@
 
 HEX_REGEX: Final[Pattern[str]] = re.compile("[a-fA-F0-9]*")
 
+MAX_CREDENTIAL_ARRAY_LENGTH = 8
+
 # Credentials are represented in hex. Whilst they are allowed a maximum length of 64
 # bytes, every byte requires 2 hex characters for representation
 _MAX_CREDENTIAL_LENGTH: Final[int] = 128
 
-MAX_CREDENTIAL_ARRAY_LENGTH = 8
-
 
 def get_credential_type_error(credential_type: str) -> Optional[str]:
     """