use filter construct for deposit_preauth validity check

XRPLF · Nov 1, 2024 · 0719107 · 0719107
1 parent 6e42798
commit 0719107
Showing 1 changed file with 13 additions and 9 deletions.
diff --git a/xrpl/models/transactions/deposit_preauth.py b/xrpl/models/transactions/deposit_preauth.py
@@ -63,17 +63,21 @@ def _get_errors(self: Self) -> Dict[str, str]:
                 + "invalid if none of the params are specified."
             )
 
+        # Filter for input parameters which are provided in the transaction
+        # Optional fields in the transaction model are set to None
         if (
-            sum(
-                [
-                    param is not None
-                    for param in (
-                        self.authorize,
-                        self.unauthorize,
-                        self.authorize_credentials,
-                        self.unauthorize_credentials,
+            len(
+                list(
+                    filter(
+                        lambda x: x is not None,
+                        [
+                            self.authorize,
+                            self.unauthorize,
+                            self.authorize_credentials,
+                            self.unauthorize_credentials,
+                        ],
                     )
-                ]
+                )
             )
             > 1
         ):