Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build vm #5284

Closed
wants to merge 2 commits into from
Closed

Build vm #5284

wants to merge 2 commits into from

Conversation

oleks-rip
Copy link
Collaborator

Checking the complexity of integrating different wasm engines into rippled

THIS PR IS FOR TEST PURPOSES ONLY

Copy link

codecov bot commented Feb 11, 2025

Codecov Report

Attention: Patch coverage is 75.62500% with 78 lines in your changes missing coverage. Please review.

Project coverage is 78.0%. Comparing base (fa5a854) to head (9f1d086).

Files with missing lines Patch % Lines
src/xrpld/app/misc/WasmVM.cpp 77.7% 57 Missing ⚠️
src/xrpld/app/tx/detail/Escrow.cpp 75.0% 10 Missing ⚠️
src/xrpld/app/tx/detail/Transactor.cpp 63.2% 7 Missing ⚠️
include/xrpl/protocol/Indexes.h 0.0% 2 Missing ⚠️
src/xrpld/app/misc/WasmVM.h 33.3% 2 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##           develop   #5284     +/-   ##
=========================================
- Coverage     78.2%   78.0%   -0.2%     
=========================================
  Files          790     792      +2     
  Lines        67638   67956    +318     
  Branches      8164    8262     +98     
=========================================
+ Hits         52860   53006    +146     
- Misses       14778   14950    +172     
Files with missing lines Coverage Δ
include/xrpl/protocol/Feature.h 100.0% <ø> (ø)
include/xrpl/protocol/TER.h 100.0% <ø> (ø)
include/xrpl/protocol/detail/ledger_entries.macro 100.0% <ø> (ø)
include/xrpl/protocol/detail/transactions.macro 100.0% <ø> (ø)
src/libxrpl/protocol/TER.cpp 100.0% <ø> (ø)
include/xrpl/protocol/Indexes.h 89.5% <0.0%> (-10.5%) ⬇️
src/xrpld/app/misc/WasmVM.h 33.3% <33.3%> (ø)
src/xrpld/app/tx/detail/Transactor.cpp 86.1% <63.2%> (-0.9%) ⬇️
src/xrpld/app/tx/detail/Escrow.cpp 64.6% <75.0%> (-19.7%) ⬇️
src/xrpld/app/misc/WasmVM.cpp 77.7% <77.7%> (ø)

... and 10 files with indirect coverage changes

Impacted file tree graph

@oleks-rip oleks-rip closed this Feb 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants