Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Failsafes to prevent a consensus round from taking too long #5277

Open
wants to merge 28 commits into
base: develop
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from 26 commits
Commits
Show all changes
28 commits
Select commit Hold shift + click to select a range
60de826
Drop out of consensus if the round takes too long
ximinez Feb 5, 2025
197356b
Declare consensus if peers enter into a stable state
ximinez Feb 5, 2025
8ad2cb3
[WIP] Consensus tests
ximinez Feb 12, 2025
7e2fa5c
[WIP] Fix builds
ximinez Feb 12, 2025
196f6b6
Merge remote-tracking branch 'upstream/develop' into ximinez/consensus
ximinez Feb 12, 2025
5108e55
Update levelization
ximinez Feb 12, 2025
5889dc5
Make ConsensusParms const, remove unnecessary copy assignment
ximinez Feb 13, 2025
69c1b00
Merge remote-tracking branch 'upstream/develop' into ximinez/consensus
ximinez Feb 13, 2025
f023ad2
Refine stable state detection:
ximinez Feb 13, 2025
d8aeb73
Merge branch 'develop' into ximinez/consensus
ximinez Feb 14, 2025
a6a2f5f
A few updates:
ximinez Feb 14, 2025
1b4163a
Merge remote-tracking branch 'upstream/develop' into ximinez/consensus
ximinez Feb 14, 2025
a396385
[WIP] Checkpoint
ximinez Feb 14, 2025
9aa953b
Merge remote-tracking branch 'upstream/develop' into ximinez/consensus
ximinez Feb 15, 2025
4a745d3
fixup! [WIP] Checkpoint
ximinez Feb 15, 2025
3c7fb74
Merge remote-tracking branch 'upstream/develop' into ximinez/consensus
ximinez Feb 20, 2025
688139f
Merge remote-tracking branch 'upstream/develop' into ximinez/consensus
ximinez Feb 20, 2025
56d78b8
Fix some bugs in stalled dispute logic, unit tests to demonstrate
ximinez Feb 25, 2025
71c1312
Merge branch 'develop' into ximinez/consensus
ximinez Feb 25, 2025
729821c
Merge remote-tracking branch 'upstream/develop' into ximinez/consensus
ximinez Feb 25, 2025
979462f
Tweak the `stalled` condition, remove some unit test logs
ximinez Feb 26, 2025
de040c9
Merge remote-tracking branch 'upstream/develop' into ximinez/consensus
ximinez Feb 27, 2025
ddd3436
Merge remote-tracking branch 'upstream/develop' into ximinez/consensus
ximinez Feb 27, 2025
e0b3b10
Add to the consensus log ("clog") in some newly added places
ximinez Feb 27, 2025
4d2f020
Merge remote-tracking branch 'upstream/develop' into ximinez/consensus
ximinez Feb 28, 2025
e196bcd
Fix build/merge errors
ximinez Feb 28, 2025
8a3341f
Merge remote-tracking branch 'upstream/develop' into ximinez/consensus
ximinez Mar 11, 2025
88cf631
Merge remote-tracking branch 'upstream/develop' into ximinez/consensus
ximinez Mar 11, 2025
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions Builds/levelization/results/ordering.txt
Original file line number Diff line number Diff line change
Expand Up @@ -42,6 +42,7 @@ test.consensus > xrpl.basics
test.consensus > xrpld.app
test.consensus > xrpld.consensus
test.consensus > xrpld.ledger
test.consensus > xrpl.json
test.core > test.jtx
test.core > test.toplevel
test.core > test.unit_test
Expand Down
2 changes: 1 addition & 1 deletion docs/consensus.md
Original file line number Diff line number Diff line change
Expand Up @@ -558,7 +558,7 @@ struct ConsensusResult
ConsensusTimer roundTime;

// Indicates state in which consensus ended. Once in the accept phase
// will be either Yes or MovedOn
// will be either Yes or MovedOn or Expired
ConsensusState state = ConsensusState::No;
};

Expand Down
Loading
Loading